Load dotenv/config before reading the config #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
changed the title
apedroferreira
approved these changes
Jan 16, 2024
| @@ -1,3 +1,4 @@ | |||
| import 'dotenv/config'; | |||
There was a problem hiding this comment.
I forgot that we also had the option to load the env in the CLI commands, just mentioning it in case it's better than importing like this in multiple files.
There was a problem hiding this comment.
It was the only way I could make it work. But you are right, we should never build things that we don't understand. I've done some further root cause analysis and after inspecting the bundles I noticed some imports before dotenv/config. I immediately remembered an issue I'd seen before. I disabled code splitting and now the ordering is predictable. Adding a big fat comment to explain why the setting is there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixes an issue when running Toolpad in
--devwhere we get fighting vite devservers messing with each other's optimized deps. Just forcing optimization when running in dev mode seems to fix it.