core: Bump package versions and fix related TS errors #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is also a small change in how we do conversion for !important. Currently, we do it by replacing ! with __IMP__ and then reconverting back. In this PR, I have changed that to just encode and decode to and from base64. So we don't need special handling for ! character
brijeshb42
force-pushed
the
bump-versions
branch
from
b454dca
to
3cbf2bd
Compare
brijeshb42
force-pushed
the
bump-versions
branch
from
de50315
to
5e63464
Compare
siriwatknp
reviewed
Nov 1, 2024
| "@types/node": "^20.5.7", | ||
| "@types/react": "^18.3.3", | ||
| "@types/react-dom": "^18.2.19", | ||
| "@types/node": "^18.19.63", |
There was a problem hiding this comment.
This's a downgrade. Is this correct?
mnajdova
approved these changes
Nov 1, 2024
| @@ -1,7 +1,7 @@ | |||
| /* eslint-env node */ | |||
| // eslint-ignore-next-line import/no-unresolved | |||
| const { withPigment } = require('@pigment-css/nextjs-plugin'); | |||
| const { experimental_extendTheme: extendTheme } = require('@mui/material/styles'); | |||
| const { extendTheme } = require('@mui/material/styles'); | |||
There was a problem hiding this comment.
For a next PR, we could just use createTheme with the css vars option.
| "@mui/system": "next", | ||
| "@mui/icons-material": "next", | ||
| "clsx": "^2.1.0", | ||
| "@mui/utils": "6.1.6", |
There was a problem hiding this comment.
We should replace these to latest, no?
| @@ -1,6 +1,6 @@ | |||
| export const loader = function virtualFileLoader() { | |||
| const callback = this.async(); | |||
| const resourceQuery = this.resourceQuery.slice(1); | |||
| const { source } = JSON.parse(decodeURIComponent(resourceQuery)); | |||
| return callback(null, source.replaceAll('__IMP__', '!important')); | |||
| const { source } = JSON.parse(decodeURIComponent(decodeURI(atob(resourceQuery)))); | |||
| @@ -9,7 +9,7 @@ import type { | |||
| } from '@wyw-in-js/processor-utils'; | |||
| import type { Replacements, Rules } from '@wyw-in-js/shared'; | |||
| import { ValueType } from '@wyw-in-js/shared'; | |||
| import type { CSSInterpolation } from '@emotion/css'; | |||
| import type { CSSInterpolation } from '@emotion/serialize'; | |||
There was a problem hiding this comment.
How did this breaking change land in an minor 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was one breaking change in Emotion. Some common types had been moved to
@emotion/serialize.There is also a small change in how we do conversion for !important. Currently, we do it by replacing ! with IMP and then reconverting back.
In this PR, I have changed that to just encode and decode to and from base64. So we don't need special handling for
!character.I encountered these errors while setting up the Pigment CSS docs workspace.