[code-infra] Remove releaseChangelog.mjs duplication #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this with #272. It looks like we created Pigment CSS repository from the mui/material-ui but we didn't use MUI X or Toolpad so much as a reference. If we did, we would have done this change from the start. So I imagine there more duplications like this to fix that we already have solved in code-infra for the other repositories. So likely there are more low hanging fruits like this we could go after. Anyway, one step forward. cc @mnajdova for awareness. MUI X has its own custom changelog script to better group component changes and handle MIT vs. paid content. I guess they are they only ones who needs this. Their need for a custom script might go away if we split each of the MUI X components into their own repository.