Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webpack] Fix support for webpack and add example app #174

Merged
merged 2 commits into from
Jul 23, 2024
Merged

[webpack] Fix support for webpack and add example app #174

merged 2 commits into from
Jul 23, 2024

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Jul 11, 2024 •
edited by oliviertassinari
Loading

Related to #65

@brijeshb42 brijeshb42 marked this pull request as ready for review July 12, 2024 07:54
@brijeshb42 brijeshb42 force-pushed the fix/webpack branch 2 times, most recently from 8837a80 to c16770e Compare July 15, 2024 09:28
siriwatknp
siriwatknp approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Overall, looks good. I have one minor request for the code comment.

We should look into the tests for theses plugins to verify that they don't break existing behavior.

@brijeshb42 brijeshb42 merged commit 47d3098 into mui:master Jul 23, 2024
14 of 15 checks passed
@oliviertassinari oliviertassinari added the examples Relating to /examples label Oct 13, 2024
oliviertassinari
oliviertassinari reviewed Oct 13, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great to have a working demo with webpack

examples/pigment-css-webpack-ts/README.md
To learn more about this example:

- [Pigment CSS documentation](https://github.com/mui/pigment-css/blob/master/README.md) - learn more about Pigment CSS features and APIs.
- [Vite documentation](https://vitejs.dev/guide/) - learn about Vite features and APIs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should reference webpack on this demo. #277

@oliviertassinari oliviertassinari mentioned this pull request Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
examples Relating to /examples webpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brijeshb42 @oliviertassinari @siriwatknp