[core] Simplify the CSV export #2941
Conversation
flaviendelangle
added
core
| @@ -15,6 +15,7 @@ export const GRID_CHECKBOX_SELECTION_COL_DEF: GridColDef = { | |||
| filterable: false, | |||
| disableColumnMenu: true, | |||
| disableReorder: true, | |||
| disableExport: true, | |||
There was a problem hiding this comment.
This col was removed on clipboard export but not on regular CSV export
Do we agree that it should not be on any CSV export ?
There was a problem hiding this comment.
Hmm, I think I may have missed this in the print export logic 🤐 but yes I think it should be applied to any CSV export.
Update: ok i did remember to check this https://github.com/mui-org/material-ui-x/blob/next/packages/grid/_modules_/grid/hooks/features/export/useGridPrintExport.tsx#L75 😮💨
There was a problem hiding this comment.
I missed it, but it was removed twice, once in the clipboard export and one in serialiseRow for any CSV export.
So it was in fact never exported on CSV.
I unified it and remove it in the buildCSV method.
There was a problem hiding this comment.
And by adding disableExport to the selection column, it will also hide it on the Print export 🥳
| return buildCSV({ | ||
| columns: exportedColumns, | ||
| rows: visibleSortedRows, | ||
| selectedRowIds: selection, | ||
| rowIds: exportedRowIds, |
There was a problem hiding this comment.
It does look cleaner that way. Nice.
flaviendelangle
changed the title
Extracted from #2725
buildCSVmethod should not have to be aware of the selection of the Grid.useGridCsvExportmethod inuseGridClipboardto unify behavior (for instance the selection by checkbox column removal)rowIds = rowIds.filter((id) => selectedRowIds.includes(id))was approaching a complexity ofn²