[core] Remove modern bundles #17359
[core] Remove modern bundles #17359
Conversation
LukasTy
added
core
|
Deploy preview: https://deploy-preview-17359--material-ui-x.netlify.app/ Updated pages: |
packages/x-license/package.json
Outdated
| @@ -11,17 +11,15 @@ | |||
| "homepage": "https://mui.com/x/introduction/licensing/", | |||
| "sideEffects": [ | |||
| "./utils/licenseInfo.js", | |||
| "./modern/utils/licenseInfo.js", | |||
| "./node/utils/licenseInfo.js" | |||
There was a problem hiding this comment.
node export no longer exists.
packages/x-license/package.json
Outdated
| @@ -11,17 +11,15 @@ | |||
| "homepage": "https://mui.com/x/introduction/licensing/", | |||
| "sideEffects": [ | |||
| "./utils/licenseInfo.js", | |||
| "./modern/utils/licenseInfo.js", | |||
| "./node/utils/licenseInfo.js" | |||
| "./esm/utils/licenseInfo.js" | |||
There was a problem hiding this comment.
🤔 This shouldn't be necessary I believ
There was a problem hiding this comment.
Do you mean the side effects altogether? 🤔
Or the change of paths? 🤔
node folder no longer exists, same for modern...
There was a problem hiding this comment.
this whole "sideEffects" property is copied to the package.json in the ./esm folder, so the relative location should be the same, i.e. "./esm/utils/licenseInfo.js" won't point at anything
There was a problem hiding this comment.
Thanks for spotting this. 🙏
There was a problem hiding this comment.
On the other hand, the package.json on the esm folder looks like this:
Is it expected? 🤔
There was a problem hiding this comment.
no, it's not 🤔 This is supposed to kick in. I can take a look tomorrow.
It's only very marginal. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
Follow up on mui/material-ui#45808.
Waiting for mui/material-ui#45912 to remove themodernfolder entirely.For now, the types are still copied there.
Will add a monorepo bump to this PR.
☝️ Done.
It's only a slight breaking change as mentioned here: mui/material-ui#45808 (comment).