Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Fix console warning in telemetry package #16816

Merged
merged 2 commits into from
Mar 4, 2025
Merged

[code-infra] Fix console warning in telemetry package #16816

merged 2 commits into from
Mar 4, 2025

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Mar 4, 2025 •
edited
Loading

@hasdfa Not sure you did * as package for some specific reason. That was the main issue with the console warning.

@JCQuintas JCQuintas added bug 🐛 Something doesn't work scope: code-infra Specific to the core-infra product labels Mar 4, 2025
@JCQuintas JCQuintas requested a review from hasdfa March 4, 2025 10:29
@JCQuintas JCQuintas self-assigned this Mar 4, 2025
@JCQuintas JCQuintas changed the title [code-infra] Fix console warning [code-infra] Fix console warning in telemetry package Mar 4, 2025
@mui-bot
Copy link

mui-bot commented Mar 4, 2025

Deploy preview: https://deploy-preview-16816--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d73c197

hasdfa
hasdfa approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@hasdfa hasdfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no specific reason to do * as packageJson, so it should be good.
Thanks!

@JCQuintas JCQuintas merged commit d8d7071 into mui:master Mar 4, 2025
18 checks passed
@JCQuintas JCQuintas deleted the fix-console-error-nextjs branch March 4, 2025 11:02
@JCQuintas
Copy link
Member Author

@michelengelen do we need a package: telemetry label? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasdfa hasdfa hasdfa approved these changes

Assignees

@JCQuintas JCQuintas

Labels
bug 🐛 Something doesn't work scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JCQuintas @mui-bot @hasdfa