Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Refactor: remove base form control #16634

Merged
merged 10 commits into from
Feb 18, 2025

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Feb 18, 2025

Part of the design-system agnostic work.

Remove base FormControl. This component is too MUI specific and should not exist in the core. Each component should handle its own label & context (like TextField) if applicable.

Changelog

Breaking changes

  • The slots.baseFormControl component was removed.

@romgrk romgrk added the component: data grid This is the name of the generic UI component, not the React module! label Feb 18, 2025
@romgrk romgrk requested a review from a team February 18, 2025 03:44
@mui-bot
Copy link

mui-bot commented Feb 18, 2025

@romgrk
Copy link
Contributor Author

romgrk commented Feb 18, 2025

Todo: filter form delete button hover is wrong.

@KenanYusuf
Copy link
Member

KenanYusuf commented Feb 18, 2025

Todo: filter form delete button hover is wrong.

align-items: center; here should be enough to stop the button stretching

@romgrk romgrk merged commit fd4e5b2 into mui:master Feb 18, 2025
17 of 18 checks passed
@romgrk romgrk deleted the refactor-agnostic-form-control branch February 18, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants