-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Update peer dependencies for v8 #16563
Conversation
Are you sure that it errors out because of this? 🤔 I don't think this change is needed. 🤔 |
Deploy preview: https://deploy-preview-16563--material-ui-x.netlify.app/ |
Running // ./package.json
"dependencies": {
"@mui/material": "next",
"@mui/x-charts-pro": "next", fails for me with
The same command with // ./package.json
"dependencies": {
"@mui/material": "next",
// csbci for this PR
"@mui/x-charts-pro": "https://pkg.csb.dev/mui/mui-x/commit/4ce90d46/@mui/x-charts-pro", installs correctly
We'll have to update the peer dependencies for v8 so it can work with core v7. This just sets it for the prerelease so we can test this without having to make The lock file changes are unrelated, something on master is not quite there |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Let's allow for easier ESM adoption/testing. 👍
Would it make sense to further tighten the range and remove v5? IIUC the goal is to only support last two majors.
That's a topic for the "product" finalize, but based on brief discussion on Friday, we don't feel like it would be for the better product wise. 🤷
Add the
7.0.0-alpha
range as currently it errors onnpm install
.edit: To clarify, it errors on end-users trying to install both
next
targets of core and X side-by-side. X doesn't accept the new core v7 alpha packages as a peer dependency yet.Questions: