[charts] Add docs for scatter "Size" section #16556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardobelchior
force-pushed
the
document-scatter-size
branch
from
811a990 to
2bc011c
Compare
bernardobelchior
requested review from
alexfauquette and
JCQuintas
and removed request for
alexfauquette
|
Deploy preview: https://deploy-preview-16556--material-ui-x.netlify.app/ Updated pages: |
bernardobelchior
added
docs
CodSpeed Performance ReportMerging #16556 will not alter performanceComparing Summary
|
alexfauquette
approved these changes
Feb 13, 2025
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Signed-off-by: Bernardo Belchior <Bernardo.belchior1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document how to customize the size of scatter points.
Related to this comment.
One thing I'd like your input on is that at the moment the scatter points are hardcoded to render as circles. The impact of this is the
markerSizeis not the width of the marker, but rather the radius, so amarkerSizeof 10 is equally a circle of width 20. I find this a bit odd. Would it make sense to change this? I think we'll need to do this change eventually if we want to support more/custom shapes.