[data grid] Add "No columns" overlay #16543
Conversation
KenanYusuf
added
component: data grid
Localization writing tips ✍️Seems you are updating localization 🌍 files. Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️
Deploy preview: https://deploy-preview-16543--material-ui-x.netlify.app/ Updated pages: |
| @@ -466,6 +467,7 @@ export const useGridColumnHeaders = (props: UseGridColumnHeadersProps) => { | |||
| role="row" | |||
| aria-rowindex={depth + 1} | |||
| ownerState={rootProps} | |||
| style={{ height: groupHeaderHeight }} | |||
There was a problem hiding this comment.
Not sure whether this could be classified as a breaking change or not. The height of the headers are applied to the header rows rather than header cells so that it does not collapse when there are no cells in it.
There was a problem hiding this comment.
I would say no, since it is a direct style and not class move
otherwise we would not be able to change anything
| @@ -466,6 +467,7 @@ export const useGridColumnHeaders = (props: UseGridColumnHeadersProps) => { | |||
| role="row" | |||
| aria-rowindex={depth + 1} | |||
| ownerState={rootProps} | |||
| style={{ height: groupHeaderHeight }} | |||
There was a problem hiding this comment.
I would say no, since it is a direct style and not class move
otherwise we would not be able to change anything
packages/x-data-grid/src/components/containers/GridRootStyles.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com> Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
Closes #14396 and #14395
https://deploy-preview-16543--material-ui-x.netlify.app/x/react-data-grid/overlays/#no-columns-overlay
No columns
No visible columns
Changelog
Breaking changes
main--hasSkeletonLoadingOverlayclass has been renamed tomain--hiddenContentand is now also applied when the "No columns" overlay is displayed.