Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix console warning in browser test on React 18 #16378

Closed

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jan 29, 2025

Follow-up on #16266.

Fixes the failing browser test pipeline on React 18 (eg.: https://app.circleci.com/pipelines/github/mui/mui-x/79592/workflows/0e381e70-f05e-4df4-bb91-4b1dfd522d7e/jobs/453295).

Setting the rowCount on the expected object solves the issue.

@LukasTy LukasTy added the test label Jan 29, 2025
@LukasTy LukasTy requested a review from arminmeh January 29, 2025 10:33
@LukasTy LukasTy self-assigned this Jan 29, 2025
@mui-bot
Copy link

mui-bot commented Jan 29, 2025

Deploy preview: https://deploy-preview-16378--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 32c35a5

@arminmeh
Copy link
Contributor

I have updated this test here #16101
and will merge it today
there are no baselineProps anymore 🙂

let's see if the problem is still there after merge

@LukasTy
Copy link
Member Author

LukasTy commented Jan 29, 2025

let's see if the problem is still there after merge

Ok, thanks for letting me know. 👌
I've ran CI on React 18 on this branch and it looks golden. 👌

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 29, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@LukasTy
Copy link
Member Author

LukasTy commented Jan 29, 2025

I have updated this test here #16101
and will merge it today
there are no baselineProps anymore 🙂

@arminmeh , I assume you did not run tests on React 18 before merging? 🙈
https://app.circleci.com/pipelines/github/mui/mui-x/79788/workflows/31243fb9-6369-4644-81eb-9e8fa88f6ba2

@LukasTy LukasTy closed this Jan 29, 2025
@LukasTy LukasTy deleted the fix-browser-test-warning-on-react-18 branch January 29, 2025 11:57
@arminmeh
Copy link
Contributor

Missread the

I've ran CI on React 18 on this branch and it looks golden

as
I've ran CI on React 18 on the branch and it looks golden 🤦🏻‍♂️

I will check it out and make another PR with R18 fix

@arminmeh
Copy link
Contributor

#16386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants