-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] New default colors #16373
[charts] New default colors #16373
Conversation
Deploy preview: https://deploy-preview-16373--material-ui-x.netlify.app/ |
CodSpeed Performance ReportMerging #16373 will not alter performanceComparing Summary
|
@noraleonte I would be in favor of removing one of the two blue and the yellow (or orange)because they still hev the issue of not being easy to distinguish |
They look good on my macbook, but on my regular screen they are very similar to each other indeed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort here 🎉 Leaving a small update on the colors
- adjusted for dark mode (thanks for the head start on that)
- adjusted the two blues (they should be a lot easier to differentiate now)
- changed the order
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎨 That's refresing 👍
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com> Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
rainbowSurgePalette
paletteChangelog
blueberryTwilightPalette
from@mui/x-charts/colorPalettes
and keep using the old colors.