Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] New default colors #16373

Merged
merged 7 commits into from
Jan 30, 2025
Merged

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Jan 28, 2025

  • Simply update the default colors to use the new rainbowSurgePalette palette
  • Added a variation of the palette for dark mode, TBD by design

Changelog

  • The default colors have changed. If you want to use the old palette, you can import blueberryTwilightPalette from @mui/x-charts/colorPalettes and keep using the old colors.

@JCQuintas JCQuintas added breaking change enhancement This is not a bug, nor a new feature component: charts This is the name of the generic UI component, not the React module! v8.x labels Jan 28, 2025
@JCQuintas JCQuintas self-assigned this Jan 28, 2025
@mui-bot
Copy link

mui-bot commented Jan 28, 2025

Deploy preview: https://deploy-preview-16373--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d35ef43

Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #16373 will not alter performance

Comparing JCQuintas:new-default-colors (d35ef43) with master (07201fb)

Summary

✅ 6 untouched benchmarks

@alexfauquette
Copy link
Member

@noraleonte I would be in favor of removing one of the two blue and the yellow (or orange)because they still hev the issue of not being easy to distinguish

image

@JCQuintas
Copy link
Member Author

@noraleonte I would be in favor of removing one of the two blue and the yellow (or orange)because they still hev the issue of not being easy to distinguish

They look good on my macbook, but on my regular screen they are very similar to each other indeed

Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort here 🎉 Leaving a small update on the colors

  • adjusted for dark mode (thanks for the head start on that)
  • adjusted the two blues (they should be a lot easier to differentiate now)
  • changed the order

Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎨 That's refresing 👍

@JCQuintas JCQuintas merged commit cff9176 into mui:master Jan 30, 2025
19 checks passed
@JCQuintas JCQuintas deleted the new-default-colors branch January 30, 2025 10:52
A-s-h-o-k pushed a commit to A-s-h-o-k/mui-x that referenced this pull request Feb 4, 2025
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature v8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants