Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Remove component for axis event listener #16314

Merged
merged 9 commits into from
Feb 4, 2025

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Jan 23, 2025

I noticed we still had a disableAxisListener and onAxisClick in dedicated hooks. I moved them to the axis plugging such that:

  • If you have cartesian axis => the axis listener are availabale
  • If you don't have the cartesian puggin => the axis listener are not running 🎉

By doing that I got two side effect:

@alexfauquette alexfauquette added breaking change component: charts This is the name of the generic UI component, not the React module! labels Jan 23, 2025
@mui-bot
Copy link

mui-bot commented Jan 23, 2025

Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #16314 will not alter performance

Comparing alexfauquette:clickHandler (7bf39e7) with master (78ba75c)

Summary

✅ 6 untouched benchmarks

@alexfauquette alexfauquette marked this pull request as ready for review January 23, 2025 17:18
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 29, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 30, 2025
@alexfauquette alexfauquette merged commit b252b9a into mui:master Feb 4, 2025
16 of 17 checks passed
JCQuintas pushed a commit to JCQuintas/mui-x that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts] onAxisClick is not working on IOS
3 participants