[code-infra] Add 'use client' directive #16273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-16273--material-ui-x.netlify.app/ |
|
Does this mean this script will not be needed anymore? https://github.com/mui/mui-x/blob/add0c954ee19a2b768cc9a19ffac56c11d7fd278/packages/rsc-builder/buildRsc.ts |
JCQuintas
approved these changes
Jan 21, 2025
LukasTy
reviewed
Jan 21, 2025
|
The script should become obsolete as the eslint rule includes an autofix. Its detection logic on when to add the directive may be built on different principles though. I'm removing rsc-builder altogether. |
JCQuintas
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the eslint update that mandates this directive in entrypoint files that use react client APIs. You can also just run
eslint --fixnext time you update the monorepo.