[DataGrid] Consider columnGroupHeaderHeight prop in getTotalHeaderHeight method
#15915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-15915--material-ui-x.netlify.app/ |
|
Hi @michelengelen , could you review this? I've changed your suggested diff a little to keep things simple, let me know if you see any problem with that. |
zannager
added
the
component: data grid
KenanYusuf
approved these changes
Dec 18, 2024
KenanYusuf
pushed a commit
to KenanYusuf/mui-x
that referenced
this pull request
Dec 18, 2024
lauri865
pushed a commit
to lauri865/mui-x
that referenced
this pull request
Dec 19, 2024
LukasTy
pushed a commit
to LukasTy/mui-x
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15874
https://deploy-preview-15915--material-ui-x.netlify.app/x/react-data-grid/column-groups/#group-header-height