Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve Romanian (ro-RO) locale #15745

Merged
merged 3 commits into from
Dec 5, 2024
Merged

[l10n] Improve Romanian (ro-RO) locale #15745

merged 3 commits into from
Dec 5, 2024

Conversation

rares985
Copy link
Contributor

@rares985 rares985 commented Dec 5, 2024

Improve Romanian (ro-RO) locale: I have added the missing keys #3211

@mui-bot
Copy link

mui-bot commented Dec 5, 2024 •
edited by noraleonte
Loading

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-15745--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 090d769

@flaviendelangle flaviendelangle added component: data grid This is the name of the generic UI component, not the React module! l10n localization labels Dec 5, 2024
@KenanYusuf KenanYusuf added needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Dec 5, 2024
noraleonte
noraleonte reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌 Thanks for the contribution 🎉 Leaving just a super small nitpick here:

packages/x-data-grid/src/locales/roRO.ts Outdated Show resolved Hide resolved
@noraleonte
Update packages/x-data-grid/src/locales/roRO.ts
090d769 
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
@noraleonte noraleonte merged commit 0e443e9 into mui:master Dec 5, 2024
18 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
@rares985 @KenanYusuf
@noraleonte @web-flow
[l10n] Improve Romanian (ro-RO) locale (#15745)
7ef90ad 
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
Co-authored-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Merged
@rares985 rares985 deleted the improve-ro-locale branch December 10, 2024 15:12
@LukasTy LukasTy added the component: pickers This is the name of the generic UI component, not the React module! label Dec 12, 2024
LukasTy pushed a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
@rares985 @KenanYusuf
@noraleonte @LukasTy
[l10n] Improve Romanian (ro-RO) locale (mui#15745)
cd5df2d 
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
Co-authored-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noraleonte noraleonte noraleonte approved these changes

@arminmeh arminmeh Awaiting requested review from arminmeh

@KenanYusuf KenanYusuf Awaiting requested review from KenanYusuf

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! l10n localization needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rares985 @mui-bot @noraleonte @flaviendelangle @LukasTy @KenanYusuf