[pickers] Use the new ownerState object for the clock components and the desktop / mobile wrappers
#15669
Conversation
…the desktop / mobile wrappers
flaviendelangle
added
breaking change
component: pickers
|
Deploy preview: https://deploy-preview-15669--material-ui-x.netlify.app/ |
flaviendelangle
changed the title
ownerState object for the clock components and the desktop / mobile wrappers
| const { ownerState: pickerOwnerState } = usePickerPrivateContext(); | ||
| const ownerState: DigitalClockOwnerState = { | ||
| ...pickerOwnerState, | ||
| hasDigitalClockAlreadyBeenRendered: !!containerRef.current, |
There was a problem hiding this comment.
I'm cleaning the name of this property to keep everything clearly scoped (like isPickerDisabled vs disabled).
| /** | ||
| * The current meridiem mode of the clock. | ||
| */ | ||
| clockMeridiemMode: Meridiem | null; |
There was a problem hiding this comment.
Same, I'm correctly scoping isClockDisabled to the clock to distinguish it from isPickerDisabled
| @@ -370,7 +379,7 @@ export function Clock(inProps: ClockProps) { | |||
| type={type} | |||
| viewValue={viewValue} | |||
| isInner={isPointerInner} | |||
| hasSelected={hasSelected} | |||
| isBetweenTwoClockValues={isPointerBetweenTwoClockValues} | |||
There was a problem hiding this comment.
The hasSelected prop name was very unclear to be.
Since it's used in the ownerState of ClockPointer, I added a better name to it.
| @@ -63,7 +89,7 @@ const ClockNumberRoot = styled('span', { | |||
| }, | |||
| variants: [ | |||
| { | |||
| props: { inner: true }, | |||
| props: { isClockNumberInInnerRing: true }, | |||
There was a problem hiding this comment.
Same, inner was very unclear, I made the name more explicit.
| @@ -340,10 +342,11 @@ export function PickersPopper(inProps: PickerPopperProps) { | |||
| onDismiss, | |||
| open, | |||
| role, | |||
| placement, | |||
| placement = 'bottom', | |||
There was a problem hiding this comment.
I'm applying the default value here to make sure all the slots inside this file get a popperPlacement property.
|
I love the descriptive naming! ❤️ |
Co-authored-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com> Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
…d the desktop / mobile wrappers (mui#15669) Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Part of #14475