Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump React router to ^6.28.0 #15362

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Bump React router to ^6.28.0 #15362

merged 9 commits into from
Dec 3, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 10, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
react-router (source) ^6.27.0 -> ^6.28.0 age adoption passing confidence
react-router-dom (source) ^6.27.0 -> ^6.28.0 age adoption passing confidence

Release Notes

remix-run/react-router (react-router)

v6.28.0

Compare Source

Minor Changes
    • Log deprecation warnings for v7 flags (#​11750)
    • Add deprecation warnings to json/defer in favor of returning raw objects
      • These methods will be removed in React Router v7
Patch Changes
  • Update JSDoc URLs for new website structure (add /v6/ segment) (#​12141)
  • Updated dependencies:
    • @remix-run/router@1.21.0
remix-run/react-router (react-router-dom)

v6.28.0

Compare Source

Minor Changes
    • Log deprecation warnings for v7 flags (#​11750)
    • Add deprecation warnings to json/defer in favor of returning raw objects
      • These methods will be removed in React Router v7
Patch Changes
  • Update JSDoc URLs for new website structure (add /v6/ segment) (#​12141)
  • Updated dependencies:
    • react-router@6.28.0
    • @remix-run/router@1.21.0

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Update of dependencies label Nov 10, 2024
@mui-bot
Copy link

mui-bot commented Nov 10, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15362--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 5dd0972

@renovate Renovate
Copy link
Contributor Author

renovate bot commented Nov 12, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@JCQuintas
Copy link
Member

Argos changes seem fun on this one 👀

@LukasTy
Copy link
Member

LukasTy commented Nov 12, 2024

Argos changes seem fun on this one 👀

🤣
Those future flags clearly impact "something". 🙈 😆

@JCQuintas
Copy link
Member

Could we drop react router? 😅

It is used in e2e and regressions for building the test page. There are probably better alternatives, though not sure about perf.

We could render html to file and simply serve/render the HTML 🤔

@LukasTy
Copy link
Member

LukasTy commented Nov 12, 2024

It is used in e2e and regressions for building the test page. There are probably better alternatives, though not sure about perf.

We could render html to file and simply serve/render the HTML 🤔

We probably could.
If router usage proves problematic, we can look into moving away from it. 🤔

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 13, 2024
@LukasTy LukasTy mentioned this pull request Dec 3, 2024
Merged
1 task
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 3, 2024
JCQuintas
JCQuintas reviewed Dec 3, 2024
View reviewed changes
test/regressions/index.test.ts
) {
);

const isReactRouterFlagsError = msg?.includes('React Router Future Flag Warning');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasTy we should be able to simply ignore the warnings for now. We can postpone this problem for when RRv7 releases 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it. 😆 🥷 🙈

@JCQuintas JCQuintas enabled auto-merge (squash) December 3, 2024 13:06
@JCQuintas JCQuintas merged commit 8bfe9da into master Dec 3, 2024
16 checks passed
@JCQuintas JCQuintas deleted the renovate/react-router branch December 3, 2024 13:13
LukasTy added a commit to LukasTy/mui-x that referenced this pull request Dec 19, 2024
@renovate @LukasTy @JCQuintas
Bump React router to ^6.28.0 (mui#15362)
6303408 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lukas Tyla <llukas.tyla@gmail.com>
Co-authored-by: Jose Quintas <juniorquintas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCQuintas JCQuintas JCQuintas approved these changes

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
dependencies Update of dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mui-bot @JCQuintas @LukasTy