Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] ON HOLD - Use the new ownerState in all the toolbars and stop passing variant and isLandscape to any component #15300

Closed
wants to merge 13 commits into from

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 6, 2024

That one was a rabbit hole, I'm splitting it into pieces 😬

@flaviendelangle flaviendelangle self-assigned this Nov 6, 2024
@flaviendelangle flaviendelangle added component: pickers This is the name of the generic UI component, not the React module! breaking change labels Nov 6, 2024
@flaviendelangle flaviendelangle force-pushed the toolbar-ownerState branch 2 times, most recently from 02e5152 to 58d4efb Compare November 6, 2024 14:55
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 12, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 15, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 19, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 19, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@flaviendelangle flaviendelangle added the on hold There is a blocker, we need to wait label Nov 20, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 20, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@flaviendelangle flaviendelangle changed the title [pickers] Use the new ownerState in all the toolbars and stop passing variant and isLandscape to any component [pickers] BLOCKED Use the new ownerState in all the toolbars and stop passing variant and isLandscape to any component Nov 22, 2024
@flaviendelangle flaviendelangle changed the title [pickers] BLOCKED Use the new ownerState in all the toolbars and stop passing variant and isLandscape to any component [pickers] ON HOLD - Use the new ownerState in all the toolbars and stop passing variant and isLandscape to any component Nov 22, 2024
@flaviendelangle
Copy link
Member Author

Solved by #15492, #15777 and #15606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! on hold There is a blocker, we need to wait PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants