-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Stop using utils in locales #14505
[pickers] Stop using utils in locales #14505
Conversation
Localization writing tips ✍️Seems you are updating localization 🌍 files. Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️
Deploy preview: https://deploy-preview-14505--material-ui-x.netlify.app/ |
6d4b7ff
to
6c5ee15
Compare
6c5ee15
to
fcb0c56
Compare
packages/x-date-pickers/src/locales/utils/pickersLocaleTextApi.ts
Outdated
Show resolved
Hide resolved
d3581a8
to
14115d2
Compare
14115d2
to
87a1495
Compare
87a1495
to
7f999ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of it! 🙏
The DX looks great. 👍
We are going to clean this up nicely on 8. 👌
packages/x-date-pickers/src/DesktopDatePicker/DesktopDatePicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/DesktopDateTimePicker/DesktopDateTimePicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/DesktopTimePicker/DesktopTimePicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/MobileDatePicker/MobileDatePicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/MobileDateTimePicker/MobileDateTimePicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/MobileTimePicker/MobileTimePicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/locales/utils/pickersLocaleTextApi.ts
Outdated
Show resolved
Hide resolved
bfa9928
to
01d8427
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 🚀 💯
Fixes #13768
I need to avoid 2 type of breaking changes
value
andutils
)formattedDate
yet)So I'm handling both the old and the new format in each locale.
This is not clean code, but we can clean it easily during the alpha and the end result will be even better than before this PR.
New DX
In v7
In v8
Follow up
value
andutils
params fromopenDatePickerDialogue
,openTimePickerDialogue
andclockLabelText