-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Fix column definition undefined value #14456
Conversation
Deploy preview: https://deploy-preview-14456--material-ui-x.netlify.app/ |
@@ -1,4 +1,5 @@ | |||
import * as React from 'react'; | |||
import resolveProps from '@mui/utils/resolveProps'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's to be noted that this helper handles a few properties differently, so to be careful with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there is custom code if slots
or componentsor
slotsPropsor
componentsProps` are passed.
Looks like CI has passed without any failed tests. So i'm expecting using resolveProps
would be OK.
@romgrk Hi! I noticed the PR has been approved but not merged yet, Let me know if there's anything else you'd like me to address. Thanks! |
All good, do you have the permissions set up to merge the PR? For internal contributions I usually let people merge themselves. |
Got it, no. I don't have permissions to merge PR |
Closes #14446
Before: https://codesandbox.io/p/sandbox/wispy-paper-mfjzqs?file=%2Fsrc%2FDemo.tsx%3A1%2C1-23%2C1
After: https://codesandbox.io/p/sandbox/withered-surf-chyrgn?file=%2Fsrc%2FDemo.tsx