Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Fix column definition undefined value #14456

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Sep 2, 2024

@sai6855 sai6855 added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Sep 2, 2024
@sai6855 sai6855 marked this pull request as draft September 2, 2024 11:52
@mui-bot
Copy link

mui-bot commented Sep 2, 2024

Deploy preview: https://deploy-preview-14456--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 6052219

@@ -1,4 +1,5 @@
import * as React from 'react';
import resolveProps from '@mui/utils/resolveProps';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to be noted that this helper handles a few properties differently, so to be careful with it.

Copy link
Contributor Author

@sai6855 sai6855 Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there is custom code if slots or componentsorslotsPropsorcomponentsProps` are passed.

https://github.com/mui/material-ui/blob/e13f1c9e37aa986624dddc44c19325d5bd97f455/packages/mui-utils/src/resolveProps/resolveProps.ts#L26

https://github.com/mui/material-ui/blob/e13f1c9e37aa986624dddc44c19325d5bd97f455/packages/mui-utils/src/resolveProps/resolveProps.ts#L21

Looks like CI has passed without any failed tests. So i'm expecting using resolveProps would be OK.

@sai6855 sai6855 marked this pull request as ready for review September 2, 2024 12:40
@sai6855
Copy link
Contributor Author

sai6855 commented Sep 30, 2024

@romgrk Hi! I noticed the PR has been approved but not merged yet, Let me know if there's anything else you'd like me to address. Thanks!

@romgrk
Copy link
Contributor

romgrk commented Sep 30, 2024

All good, do you have the permissions set up to merge the PR? For internal contributions I usually let people merge themselves.

@sai6855
Copy link
Contributor Author

sai6855 commented Sep 30, 2024

All good, do you have the permissions set up to merge the PR? For internal contributions I usually let people merge themselves.

Got it, no. I don't have permissions to merge PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] Column definition undefined value
4 participants