Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Use describeTreeView for remaining items tests #13262

Merged
merged 14 commits into from
May 29, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented May 27, 2024

Part of #12433

And we are good 🥳

@flaviendelangle flaviendelangle self-assigned this May 27, 2024
@flaviendelangle flaviendelangle added test core Infrastructure work going on behind the scenes labels May 27, 2024
@flaviendelangle flaviendelangle changed the title [test] Use describeTreeView for remaining items tests [WIP] [test] Use describeTreeView for remaining items tests [WIP] May 27, 2024
@mui-bot
Copy link

mui-bot commented May 27, 2024

Deploy preview: https://deploy-preview-13262--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 7945987

@flaviendelangle flaviendelangle marked this pull request as ready for review May 28, 2024 08:30
@flaviendelangle flaviendelangle changed the title [test] Use describeTreeView for remaining items tests [WIP] [test] Use describeTreeView for remaining items tests May 28, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice improvement! LGTM! :shipit:

@flaviendelangle flaviendelangle merged commit 37e991f into mui:master May 29, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the items-describeTreeView-end branch May 29, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants