-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Add support mobile tooltip #13043
[charts] Add support mobile tooltip #13043
Conversation
Deploy preview: https://deploy-preview-13043--material-ui-x.netlify.app/ |
That's kinda cool, thanks for your contribution. :D Do you have any insights on why |
The workarounds found don’t look very good and can lead to performance issues. So I didn’t add them. |
@alexfauquette current issue with mouse events in |
I'm not sure to understand what you're proposing. The But for items, we don't have a simple way to map You are proposing to put a By the way, items are already visible if you click on them I assume we can add this fix which is already an improvement, and fix the item aspect in another one |
yes, I was thinking something like that. I'm aware the items are visible on click, but this MR is about making "dragging" your finger around work seamlessly, without having to click again.
Agree |
Resolves: #13041
Added tracking of touch events for correct operation on mobile devices. This works in case of an
axis
trigger.This solution does not work for an
item
trigger. It is necessary to come up with a solution for this case.Preview: https://deploy-preview-13043--material-ui-x.netlify.app/x/react-charts/tooltip/