[core] Use the same react pattern everywhere #9520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
core-use-react
branch
from
73b7996
to
9eadd5a
Compare
oliviertassinari
force-pushed
the
core-use-react
branch
from
9eadd5a
to
53f34ba
Compare
oliviertassinari
force-pushed
the
core-use-react
branch
from
53f34ba
to
5129ed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
import React from 'react';for 90%+ of the codebase. Now, it's 100%.The main argument for doing it the other way around is code splitting. But given React needs to be imported for
React.createElement. It's unlikely we will ever see code splitting working with React.So, instead, let's improve gzipped efficiency. It's reducing the entropy of the project 🎉 .