RenderToLayer: removed touchstart events, to prevent double call for … #9118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…callback onRequestClose
|
@midan888 I like the idea but it might broke the nested menu feature. To verify. |
|
@oliviertassinari had you time to test this one, does it break anything ? |
|
@midan888 Works great for me - Thanks! 👍 |
|
@hai-cea Cool thanks! |
djbuckley
added a commit
to manchesergit/material-ui
that referenced
this pull request
Dec 18, 2017
* call_em_all_-_master/master: Add Governance Document (mui#9423) [docs] Add HEAD back as it's only here for the dev [docs] Remove HEAD in versions list (mui#9391) [docs] Adding smpl to showcase (mui#9386) Update CHANGELOG.md [Docs] Add v0.20.0 to versions.json v0.20.0 [CHANGELOG] Prepare v0.20.0 (mui#9375) [docs] Update build-script & document docs publishing process (mui#9374) [Menu] use filtered children on setFocusIndexStartsWith (mui#9316) Fix Updating min and max Props on Slider (mui#9261) RenderToLayer: removed touchstart events, to prevent double call for callback onRequestClose (mui#9118) [Legacy] Removes 'TouchTap' in favor of `Click` throughout library and docs (mui#9058) [npm] Upgrades 'inline-style-prefixer' to 3.0.8 (mui#9320) [docs] Updates Home h2 text to match v1 (mui#9060) # Conflicts: # src/AppBar/AppBar.js # src/AutoComplete/AutoComplete.js # src/DatePicker/DateDisplay.js # src/DatePicker/DatePicker.js # src/DatePicker/DatePickerDialog.js # src/Tabs/Tab.js # src/Tabs/Tabs.js # src/internal/EnhancedButton.js
This was referenced Feb 23, 2020
This was referenced Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onRequestClose callback listens for two events, touchstart and click.
On touch device both events actually fired, so the callback called twice, which brings errors in application, so its better to remove it rather handle double call in the application