[AutoComplete] Fix issue with popover positioning on iOS #7333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you saying iOS Safari fixed the issue? 😄 Is keeping the support for the older version needed? I guess not. |
|
Yep– iOS 10.3 was the magic version! It seems to have roughly 3/4 of the iOS share. |
djbuckley
added a commit
to manchesergit/material-ui
that referenced
this pull request
Jul 5, 2017
* call_em_all_-_master/master: [Docs] Add v0.18.6 to versions.json 0.18.6 [CHANGELOG] Extra information [CHANGELOG] Prepapre v0.18.6 [TextField] Fix unfocused state when disabled (mui#7283) [DatePicker] Use pickerHeaderColor muiTheme property for DatePicker header customization (mui#7295) [ListItem] Apply paddingRight to automatic expand icon (mui#7313) [AutoComplete] Fix issue with popover positioning on iOS (mui#7333)
oliviertassinari
added
the
component: autocomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Popover uses a helper
iOSHelpers.jsto make specific calculations for iOS. However, it seems to be useless with last Mobile Safari versions. Worse yet, it generates a bug with calculations:See #5544 for more details.