Use a different approach for preventing ghost click ripples #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai-cea
added a commit
that referenced
this pull request
May 10, 2015
Use a different approach for preventing ghost click ripples
|
Thanks @pomerantsev ! |
zannager
added
the
package: styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #456.
This PR essentially reverts most of the changes made in #543, since on iOS, two ripples still could be seen (I did not test it there initially). It was happening because a click event happens 300ms after touchend, and if we just increased the timeout to something like 400ms, a ghost ripple would still be seen if a user tapped twice with a small interval.
So rather than setting a timeout on every touchend, here I'm just checking if there are any touch-generated ripples when handling the click event. If so, no new ripple should be generated.