[TextField] - Implement helper text/error text as a separate component #4526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for this issue #2555, and it's also covers this #2474 issue, but I don't think that PR is complete and we need to discuss few things.
For example here I've used
adjustForMultiLine
andadjustForFloatingLabel
"private" props that should be sent only fromTextField
.Reason why I used it - it's to encapsulate component stylings in it, otherwise it would be hard to find where changed comes from - custom
TextField
styles, ownTextField
styles, customTextFieldHelper
styles or ownTextFieldHelper
styles.So as I see the future implementation will look like:
or if you want to add some stylings
Similar for all
TextField
child componentsSome thing that can be also done here:
errorStyle
prop to avoid things like that -{color: error ? 'orange' : 'blue'}
...restProps
to div