Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][Dialog] Removes deprecated PaperProps from docs #45195

Merged
merged 3 commits into from
Feb 5, 2025
Merged

[docs][Dialog] Removes deprecated PaperProps from docs #45195

merged 3 commits into from
Feb 5, 2025

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Feb 3, 2025 •
edited
Loading

PaperProps prop is deprecated but still being suggested in docs, this PR removes all instances of PaperProps from Dialog demos

@sai6855 sai6855 added docs Improvements or additions to the documentation component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material enhancement This is not a bug, nor a new feature labels Feb 3, 2025
@mui-bot
Copy link

mui-bot commented Feb 3, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-45195--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0c3640d

@zannager zannager requested a review from siriwatknp February 4, 2025 12:04
ZeeshanTamboli
ZeeshanTamboli approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sai6855 Looks good. Changes in docs should be tagged with [docs], not [material-ui] in the PR title. Also this should be cherry-picked to v6.

@sai6855 sai6855 changed the title [material-ui][Dialog] Removes deprecated PaperProps from docs [docs][Dialog] Removes deprecated PaperProps from docs Feb 5, 2025
@sai6855
Copy link
Contributor Author

sai6855 commented Feb 5, 2025

@sai6855 Looks good. Changes in docs should be tagged with [docs], not [material-ui] in the PR title. Also this should be cherry-picked to v6.

Noted

@sai6855 sai6855 added the needs cherry-pick The PR should be cherry-picked to master after merge label Feb 5, 2025
@sai6855 sai6855 merged commit ca28081 into mui:master Feb 5, 2025
23 checks passed
@ZeeshanTamboli
Copy link
Member

@sai6855 Two labels needs: cherry-pick and v6.x labels should be added before merging for it to work. You'll need to create the cherry-pick PR manually now.

@sai6855
Copy link
Contributor Author

sai6855 commented Feb 5, 2025

Ah okay, I'll create

sai6855 added a commit to sai6855/material-ui that referenced this pull request Feb 5, 2025
@sai6855
[docs][Dialog] Removes deprecated PaperProps from docs (mui#45195)
6e8b663
@sai6855 sai6855 mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai6855 @mui-bot @ZeeshanTamboli