Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][Select] Update docs to reflect the omission of placeholder prop #44856

Merged

Conversation

adityaparab
Copy link
Contributor

@adityaparab adityaparab commented Dec 25, 2024

Part of #44821

This PR adds a warning to the Select docs page to point out that the placeholder prop is not available in Select. The Select API page is not updated in this PR as it needs docs infra work to add such a one-off text.

@aarongarciah aarongarciah changed the title [docs][Selects] update docs to reflect the omission of placeholder pr… [docs][Select] update docs to reflect the omission of placeholder pr… Dec 25, 2024
@aarongarciah aarongarciah added component: select This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Dec 25, 2024
@aarongarciah aarongarciah changed the title [docs][Select] update docs to reflect the omission of placeholder pr… [docs][Select] Update docs to reflect the omission of placeholder prop Dec 25, 2024
@aarongarciah
Copy link
Member

Thanks for contributing @adityaparab! I left a comment to improve the warning copy.

@mui-bot
Copy link

mui-bot commented Dec 26, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 36566b4

@aarongarciah aarongarciah force-pushed the docs-selects-placeholer-prop-omit branch from 9485263 to 36566b4 Compare December 27, 2024 00:19
@aarongarciah aarongarciah merged commit b455d50 into mui:master Dec 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants