[core] Extract useRippleHandler outside of ButtonBase #44591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: wilhelmlofsten <wilhelmlofsten@users.noreply.github.com>
Netlify deploy previewhttps://deploy-preview-44591--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
1 task
|
Hi @albarv340, is this warning affecting your project in some way? We kinda paused the progress on #42564 until we have a clearer picture on how we'll be adopting the React Compiler (if we adopt it). |
|
Hi @aarongarciah, this warning is not affecting any project of ours in any way, so there is no hurry. We didn't see anywhere that the progress was paused, so we deemed by the "ready to take" label that we could go ahead and attempt a solution. |
aarongarciah
changed the title
aarongarciah
requested review from
romgrk
and removed request for
aarongarciah
romgrk
reviewed
Nov 29, 2024
romgrk
reviewed
Nov 29, 2024
romgrk
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested fix for #42564 with ButtonBase.js
This solves the invalid-hook-call-warning ESLint warning with the useRippleHandler hook.
There are still ref.current ESLint warnings with the current version of eslint-plugin-react-compiler, but when eslint-plugin-react-compiler is updated to the newest version, these are gone. From our understanding of the ESLint warning, it is a false positive, so the newer version is correct while the current one is not.