Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test][material-ui] Add tests for Pigment Grid and Stack #44132

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

DiegoAndai
Copy link
Member

While reviewing #44042 I noticed we didn't have tests for these components. This PR adds them.

@DiegoAndai DiegoAndai added test package: material-ui Specific to @mui/material package: pigment-css Specific to @pigment-css/* labels Oct 16, 2024
@DiegoAndai DiegoAndai requested a review from siriwatknp October 16, 2024 15:16
@DiegoAndai DiegoAndai self-assigned this Oct 16, 2024
@mui-bot
Copy link

mui-bot commented Oct 16, 2024

Netlify deploy preview

https://deploy-preview-44132--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1b80bee

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 16, 2024

I guess the next step (in the future) will be to move those to be demos on the docs. This way, we can see them in Netlify, Argos can take visual screenshots, etc.

@mnajdova
Copy link
Member

mnajdova commented Oct 22, 2024

I guess the next step (in the future) will be to move those to be demos on the docs. This way, we can see them in Netlify, Argos can take visual screenshots, etc.

@oliviertassinari we already have set up screenshot tests for Pigment CSS, it's using the fixtures directory from the vite app, check https://app.argos-ci.com/mui/material-ui/builds/32947/114088289

The main reason why I decided to use the vite app is because Pigment CSS is not used on the docs yet. We are anyway creating the whole docs page so all demos are duplicated & covered, but taken in one screenshot.

@aarongarciah aarongarciah merged commit 506e17e into mui:master Oct 22, 2024
19 checks passed
@DiegoAndai DiegoAndai deleted the pigment-layout-tests branch November 4, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: material-ui Specific to @mui/material package: pigment-css Specific to @pigment-css/* test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants