Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Fix testing library resolution with custom react #44061

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Oct 10, 2024

Currently it only updates the top-level dependency but there's a nested one in @mui/internal-test-utils. Makes the unit tests run (but not pass) for react 17.

Won't allocate more time to fixing these tests for now, but we may as well get this fix in.

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Oct 10, 2024
@mui-bot
Copy link

mui-bot commented Oct 10, 2024

Netlify deploy preview

https://deploy-preview-44061--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b660222

@Janpot Janpot marked this pull request as ready for review October 11, 2024 08:14
@Janpot Janpot requested a review from cherniavskii October 11, 2024 08:14
@Janpot Janpot requested a review from a team February 10, 2025 16:42
@Janpot Janpot merged commit 5b6489b into mui:master Feb 10, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants