Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Remove playwright docker (experiment) #43883

Closed
wants to merge 14 commits into from

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 25, 2024

Further simplify #43881 by removing the playwright docker image and installing the browsers directly:

  • the setup step decreases from ~23s to ~0s
  • the new playwright install step ranges from ~23s to ~41s

This is a decrease in terms of perfomance, but it could simplify our setup, and allow us to control the Node.js version across all jobs


Seems to have font problems.

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Sep 25, 2024
@mui-bot
Copy link

mui-bot commented Sep 25, 2024

Netlify deploy preview

https://deploy-preview-43883--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against cd81fcd

@Janpot Janpot changed the title [code-infra] Remove playwright docker (experiment) [code-infra] Remove playwright docker Sep 25, 2024
@Janpot Janpot changed the title [code-infra] Remove playwright docker [code-infra] Remove playwright docker (experiment) Sep 25, 2024
@Janpot
Copy link
Member Author

Janpot commented Sep 26, 2024

Benefits unclear at the moment

@Janpot Janpot closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants