Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][material-ui] Fix getting started with CSS variables in theme example #43658

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

Designer023
Copy link
Contributor

@Designer023 Designer023 commented Sep 8, 2024

theme variable was not used and there was a typo in the example for the basic theme implementation

`theme` variable is not used and there is a typo in the example for the basic theme implementation

Signed-off-by: Carl Topham <github@carl-topham.com>
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Sep 9, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title Fix (docs): Update basic theme example [docs][material-ui] Update basic theme example Sep 9, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui] Update basic theme example [docs][material-ui] Fix basic theme example Sep 9, 2024
@mui-bot
Copy link

mui-bot commented Sep 9, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ed48766

@ZeeshanTamboli ZeeshanTamboli changed the title [docs][material-ui] Fix basic theme example [docs][material-ui] Fix getting started with CSS variables in theme example Sep 9, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZeeshanTamboli ZeeshanTamboli merged commit ba40852 into mui:master Sep 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants