[docs] Rename jsx-runtime in window object
#43639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vxee
commented
Sep 7, 2024
•
Vxee
commented
- I have followed (at least) the PR section of the contributing guide.
1 task
Netlify deploy previewhttps://deploy-preview-43639--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
window object
|
@alexfauquette Please help to merge it when you are available, thanks. |
|
That's a breaking change. Even if it's docs, I'm not in favor of adding a breaking change for the only purpose of renaming stuff |
|
@alexfauquette I know your concern. This function is created by me. We haven't mentioned this in docs site. So I think it is low impact to rename. I rename it because I use Vite to build the js chunk, I specify the name as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.