[docs][material-ui][Autocomplete] Refactor asynchronous loading demo #43630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
docs
Netlify deploy previewhttps://deploy-preview-43630--material-ui.netlify.app/ Bundle size report |
sai6855
commented
Sep 6, 2024
| @@ -14,44 +14,30 @@ function sleep(duration) { | |||
| export default function Asynchronous() { | |||
| const [open, setOpen] = React.useState(false); | |||
| const [options, setOptions] = React.useState([]); | |||
| const loading = open && options.length === 0; | |||
There was a problem hiding this comment.
We received feedback in slack, that if empty array is returned here demo is in loading state indefinetly. So i decoupled loading state from options.
To reproduce the issue, pass empty array here and check demo
sai6855
commented
Sep 6, 2024
|
|
||
| if (!loading) { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
I also refactored the code to remove twouseEffect hooks, achieving the same functionality with more readable code.
ZeeshanTamboli
approved these changes
Sep 7, 2024
ZeeshanTamboli
changed the title
loading demo
Michael-Hutchinson
pushed a commit
to Michael-Hutchinson/material-ui
that referenced
this pull request
Sep 7, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves below feedback from slack
before Demo link: https://mui.com/material-ui/react-autocomplete/#load-on-open
after demo: https://deploy-preview-43630--material-ui.netlify.app/material-ui/react-autocomplete/#load-on-open