-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix link from v5 to v6 #43585
Conversation
alexfauquette
commented
Sep 3, 2024
- I have followed (at least) the PR section of the contributing guide.
Netlify deploy previewhttps://deploy-preview-43585--material-ui.netlify.app/ Bundle size reportBundle size will be reported once CircleCI build #743908 finishes. |
@@ -167,8 +167,8 @@ function AppWrapper(props) { | |||
name: 'Material UI', | |||
versions: [ | |||
{ | |||
text: 'v6 (next)', | |||
href: `https://next.mui.com${languagePrefix}/material-ui/getting-started/`, | |||
text: 'v6', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes sense 👍 What's with the other changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.gitignore
issues between master
and v5
. Should be fixed now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mnajdova I've added this modification to the release guide. I'm not sure it's the correct place https://www.notion.so/Core-Major-version-release-process-7601e24709b84d5fa43f20a13f7526c6?d=aa09017c89e1465db3e8782016d6b4ce&pvs=4#b0ab2c1f7455400884ef5893abe6caee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yep, that's the right place.
dbc9ebd
to
8884e26
Compare