Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Skip shadow DOM regression test #43500

Merged
merged 3 commits into from
Aug 28, 2024
Merged

[docs-infra] Skip shadow DOM regression test #43500

merged 3 commits into from
Aug 28, 2024

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Aug 28, 2024 •
edited
Loading

Part of #39766

Introducing the changes suggested in #42824 (comment) to be able to skip certain demos regression tests and skipping the shadow DOM regression test.

@aarongarciah aarongarciah added test scope: docs-infra Specific to the docs-infra product labels Aug 28, 2024
@aarongarciah aarongarciah self-assigned this Aug 28, 2024
@mui-bot
Copy link

mui-bot commented Aug 28, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 76a7d04

@aarongarciah aarongarciah marked this pull request as ready for review August 28, 2024 16:57
@aarongarciah aarongarciah mentioned this pull request Aug 28, 2024
Draft
oliviertassinari
oliviertassinari reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, very cool, one step to fix #39766

test/regressions/index.js Outdated Show resolved Hide resolved
@aarongarciah aarongarciah merged commit 029eb3b into mui:master Aug 28, 2024
22 checks passed
@aarongarciah aarongarciah deleted the filter-out-demos branch August 28, 2024 20:34
@prathik2401 prathik2401 mentioned this pull request Sep 20, 2024
Open
@Sinless777 Sinless777 mentioned this pull request Sep 20, 2024
Open
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 20, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Sep 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees

@aarongarciah aarongarciah

Labels
scope: docs-infra Specific to the docs-infra product test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aarongarciah @mui-bot @oliviertassinari @DiegoAndai