Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system][InitColorSchemeScript] Use let/const instead of var #43468

Merged
merged 6 commits into from
Aug 30, 2024
Merged

[system][InitColorSchemeScript] Use let/const instead of var #43468

merged 6 commits into from
Aug 30, 2024

Conversation

ishon19
Copy link
Contributor

@ishon19 ishon19 commented Aug 27, 2024

This PR replaces the var usage with the ES6 recommended let/const in the code snippet.

Fixes #43418

@zannager zannager added the package: system Specific to @mui/system label Aug 27, 2024
@zannager zannager requested a review from siriwatknp August 27, 2024 15:00
@oliviertassinari oliviertassinari mentioned this pull request Aug 27, 2024
Closed
1 task
@siriwatknp
Apply suggestions from code review
2226b84 
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
siriwatknp
siriwatknp approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution!

@mui-bot
Copy link

mui-bot commented Aug 28, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43468--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 149e31b

@ishon19
Copy link
Contributor Author

ishon19 commented Aug 28, 2024

👍 Thanks for your contribution!

My pleasure! Thanks for the review @siriwatknp :)

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Aug 28, 2024
@ZeeshanTamboli ZeeshanTamboli merged commit aedf366 into mui:master Aug 30, 2024
19 checks passed
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Open
Open
Open
@prathik2401 prathik2401 mentioned this pull request Sep 26, 2024
Merged
This was referenced Oct 3, 2024
Open
Open
This was referenced Oct 3, 2024
Open
Open
@Msolmaz4 Msolmaz4 mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes package: system Specific to @mui/system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[system] initColorSchemeScript.tsx uses var instead of let
6 participants
@ishon19 @mui-bot @oliviertassinari @siriwatknp @ZeeshanTamboli @zannager