-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Core] Setup umd build #4342
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
aab20f1
Added build and minify npm scripts, references #262
ANich 1c61d92
CS fix
ANich 5d94555
Added index.umd.js to export src/styles and call injectTapEventPlugin().
ANich dd64aee
Missing semi
ANich 2f10ad7
Changed target directory from build to dist (build is for the NPM pac…
ANich 4ccd66b
Added transition-group and create-fragment addons as exernals
ANich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
node_modules | ||
npm-debug.log | ||
build | ||
dist | ||
coverage | ||
|
||
# Exclude compiled files | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import injectTapEventPlugin from 'react-tap-event-plugin'; | ||
injectTapEventPlugin(); | ||
|
||
export * from './index'; | ||
export * from './styles'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
var webpack = require('webpack') | ||
|
||
module.exports = { | ||
|
||
output: { | ||
library: 'MaterialUI', | ||
libraryTarget: 'umd' | ||
}, | ||
|
||
externals: [ | ||
{ | ||
'react': { | ||
root: 'React', | ||
commonjs2: 'react', | ||
commonjs: 'react', | ||
amd: 'react' | ||
}, | ||
'react-dom': { | ||
root: 'ReactDOM', | ||
commonjs2: 'react-dom', | ||
commonjs: 'react-dom', | ||
amd: 'react-dom' | ||
}, | ||
'react-addons-transition-group': { | ||
root: ['React', 'addons', 'TransitionGroup'], | ||
commonjs2: 'react-addons-transition-group', | ||
commonjs: 'react-addons-transition-group', | ||
amd: 'react-addons-transition-group', | ||
}, | ||
'react-addons-create-fragment': { | ||
root: ['React', 'addons', 'createFragment'], | ||
commonjs2: 'react-addons-create-fragment', | ||
commonjs: 'react-addons-create-fragment', | ||
amd: 'react-addons-create-fragment', | ||
} | ||
} | ||
], | ||
|
||
module: { | ||
loaders: [ | ||
{ | ||
test: /\.js$/, | ||
loaders: ['babel'], | ||
exclude: /node_modules/ | ||
} | ||
] | ||
}, | ||
|
||
node: { | ||
Buffer: false | ||
}, | ||
|
||
plugins: [ | ||
new webpack.optimize.OccurenceOrderPlugin(), | ||
new webpack.DefinePlugin({ | ||
'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV) | ||
}) | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two targets gave errors for me. I changed them to:
and the build ran correctly.