Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Add TemplateFrame to templates #43406

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Aug 22, 2024

Follow-up to #43396 based on #43396 (comment)

Fixes the layout and double scrollbars.

👉 https://deploy-preview-43406--material-ui.netlify.app/material-ui/getting-started/templates/

@zanivan zanivan added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material design This is about UI or UX design, please involve a designer labels Aug 22, 2024
@zanivan zanivan self-assigned this Aug 22, 2024
@zanivan zanivan requested a review from aarongarciah August 22, 2024 14:15
@mui-bot
Copy link

mui-bot commented Aug 22, 2024

Netlify deploy preview

https://deploy-preview-43406--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 99e2ca2

Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The changes are causing a double scroll bars in the marketing page and blog templates:

Screenshot 2024-08-22 at 23 00 27 Screenshot 2024-08-22 at 23 01 13

btw, we should probably set the color-scheme CSS property so all scroll bars have the same color. In another PR ofc!

@zanivan
Copy link
Contributor Author

zanivan commented Aug 23, 2024

@aarongarciah what browser are you using? Tested on chrome here and couldn't reproduce it

@aarongarciah
Copy link
Member

aarongarciah commented Aug 23, 2024

@zanivan I'm seeing it in at least Chrome, Safari and Arc (which is basically Chrome) in macOS with scroll bars always visible. Firefox seems to be the only one not doing the double scroll.

Screenshot 2024-08-23 at 17 42 19

https://deploy-preview-43406--material-ui.netlify.app/material-ui/getting-started/templates/marketing-page

@zanivan
Copy link
Contributor Author

zanivan commented Aug 23, 2024

I was recording a video to show that here it's not happening and a bugger bug showed up 😅 Do you have any idea on what might be happening?

Screen.Recording.2024-08-23.at.12.45.23.mov

@aarongarciah
Copy link
Member

aarongarciah commented Aug 23, 2024

I'll take a look next week 👀 To see the double scroll bar, you need to update this macOS setting to "Always":

Screenshot 2024-08-23 at 17 49 05

@aarongarciah
Copy link
Member

@zanivan I need to look deeper but removing the footer fixes the double scroll bar and the issue you shared in the video (is the same issue).

image

@aarongarciah
Copy link
Member

Just found the culprit: the hidden label in the email input in the footer, which is absolute positioned, is causing the overflow.

Kapture.2024-08-23.at.18.46.32.mp4

@zanivan zanivan requested a review from aarongarciah August 27, 2024 12:12
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Left a couple of small comments for your consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants