Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix typescript-next CI workflow #43394

Merged
merged 6 commits into from
Aug 21, 2024
+2 −2
Merged

[core] Fix typescript-next CI workflow #43394

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee71b44
Install pnpm before installing deps
aarongarciah Aug 21, 2024
3050eec
test test_types_next job
aarongarciah Aug 21, 2024
87d4653
Revert "test test_types_next job"
aarongarciah Aug 21, 2024
ba3340e
pnpm update instead of add
aarongarciah Aug 21, 2024
5a27650
test test_types_next job
aarongarciah Aug 21, 2024
5319bac
Revert "test test_types_next job"
aarongarciah Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,13 +352,13 @@ jobs:
resource_class: 'medium+'
steps:
- checkout
- install_js
- run:
name: Resolve typescript version
command: |
pnpm add typescript@next -d -w
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could try with the following command. (Not sure it will work)

Suggested change
pnpm add typescript@next -d -w
pnpm update -r typescript@next

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It "works": https://app.circleci.com/pipelines/github/mui/material-ui/136906/workflows/efb61b97-5715-455c-915f-a008c66cd81d/jobs/738078. It fails silently because this job is meant to fail silently.

The previous command also resulted in the same error: https://app.circleci.com/pipelines/github/mui/material-ui/136902/workflows/b9c1cbb1-625e-4e3d-a68b-4da986bd0108/jobs/738050?invite=true#step-107-198

Looks like the docs:typescript command is the one failing, but probably something to look into another PR.

# log a patch for maintainers who want to check out this change
git --no-pager diff HEAD
- install_js
- run:
name: Tests TypeScript definitions
command: |
Expand Down
Loading