Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][material-ui] Prevent scrolling when restoring after FocusTrap #43301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mui-base/src/FocusTrap/FocusTrap.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ function FocusTrap(props: FocusTrapProps): React.JSX.Element {
// Once IE11 support is dropped the focus() call can be unconditional.
if (nodeToRestore.current && (nodeToRestore.current as HTMLElement).focus) {
ignoreNextEnforceFocus.current = true;
(nodeToRestore.current as HTMLElement).focus();
(nodeToRestore.current as HTMLElement).focus({ preventScroll: true });
}

nodeToRestore.current = null;
Expand Down
2 changes: 1 addition & 1 deletion packages/mui-material/src/Unstable_TrapFocus/FocusTrap.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ function FocusTrap(props: FocusTrapProps): React.JSX.Element {
// Once IE11 support is dropped the focus() call can be unconditional.
if (nodeToRestore.current && (nodeToRestore.current as HTMLElement).focus) {
ignoreNextEnforceFocus.current = true;
(nodeToRestore.current as HTMLElement).focus();
(nodeToRestore.current as HTMLElement).focus({ preventScroll: true });
}

nodeToRestore.current = null;
Expand Down
Loading