-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][material-ui] Revamp Composition
guide
#43266
Merged
ZeeshanTamboli
merged 8 commits into
mui:next
from
ZeeshanTamboli:docs-revamp-and-fix-composition-guide
Aug 19, 2024
Merged
[docs][material-ui] Revamp Composition
guide
#43266
ZeeshanTamboli
merged 8 commits into
mui:next
from
ZeeshanTamboli:docs-revamp-and-fix-composition-guide
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
docs
Improvements or additions to the documentation
package: material-ui
Specific to @mui/material
labels
Aug 12, 2024
Netlify deploy preview
Bundle size report |
1 task
I am not sure who to ask for a review here. |
1 task
Can I get a review here? |
aarongarciah
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
Co-authored-by: Aarón García Hervás <aaron.garcia.hervas@gmail.com> Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
Sorry for the delay. For next time, if it's related to structure of the docs, please include @samuelsycamore in the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the feedback provided in #41590 by improving the Composition guide.
Changes by Commit
ref
to children.<ListItem button />
with<ListItemButton>
.component
prop accepts any React component, removing an unnecessary discussion on prop forwarding.role="undefined"
fromLink
(see docs on when it's needed), asListItemButton
which rendersButtonBase
already handles therole
whento
prop is provided to it.Previews