Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Replace wrong import with @mui/material/styles #43236

Merged
merged 1 commit into from
Aug 9, 2024
Merged

[examples] Replace wrong import with @mui/material/styles #43236

merged 1 commit into from
Aug 9, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Aug 9, 2024 •
edited
Loading

closes #43221

@siriwatknp siriwatknp added the examples Relating to /examples label Aug 9, 2024
@siriwatknp siriwatknp requested a review from a team August 9, 2024 06:12
@mui-bot
Copy link

mui-bot commented Aug 9, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43236--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0ec6ae4

mnajdova
mnajdova approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, luckily it's the only example that has this import.

@siriwatknp
Copy link
Member Author

Nice catch, luckily it's the only example that has this import.

It takes me 30 minutes to find the root cause 🥲. I started to think that exporting MuiThemeProvider is a better way. I have seen issues related to emotion import many many times.

@siriwatknp siriwatknp merged commit 193bd6b into mui:next Aug 9, 2024
20 checks passed
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 17, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
examples Relating to /examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Theme defaultProps do not get applied since 5.16.0
3 participants
@siriwatknp @mui-bot @mnajdova