[website] Fix strange focus-visible on hover #42924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-42924--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
website-fix-focus-visible
branch
2 times, most recently
from
bafce59
to
a88dfbe
Compare
oliviertassinari
force-pushed
the
website-fix-focus-visible
branch
from
a88dfbe
to
7afaa17
Compare
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open https://next.mui.com/.
Screen.Recording.2024-07-14.at.01.38.14.mov
A regression from #42603.
I think the root of the bug is w3c/csswg-drafts#5885.
The navigation menu logic itself on the website pages feels a bit broken. For example, I'm confused as for why one works with tabs and the other is a composite widget (works with arrows), it feels like this should truly be abstracted into a Base UI module but 🤷♂️ for now, no time. I have noticed this problem from #42767. @andy-hook this make me think of radix-ui/primitives#1172, and why it was a great move.
Preview: https://deploy-preview-42924--material-ui.netlify.app/