[AutoComplete] Fix onNewRequest not firing on iOS #4291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
changed the title
| @@ -325,7 +325,9 @@ class AutoComplete extends Component { | |||
|
|
|||
| handleBlur = (event) => { | |||
| if (this.state.focusTextField && this.timerTouchTapCloseId === null) { | |||
| this.close(); | |||
| setTimeout(() => { | |||
There was a problem hiding this comment.
It appears that handleBlur is executed before handleItemTouchTap
Interesting! In that case, should we defer the all if block into a setTimeout?
Shouldn't we also clear the timeout during the unmounting?
oliviertassinari
force-pushed
the
master
branch
from
53b828e
to
ea2538e
Compare
oliviertassinari
added
PR: needs revision
|
I couldn't reproduce this behavior on an iOS10.1 iPhone 6 simulator. |
|
I can confirm we are still seeing this behavior running our Cordova app on iphone6 with iOS v10.11. Same behavior with iOS v9.3.x Don't see this issue when running from iOS and accessing web browser version of our app using Safari mobile. |
|
Any progress on merging this PR? This happens on Cordova iOS. It is also worth to mention that this issue does not appear on longer item press. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/ docs demo, and is linted.Closes #4290