Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui] Fix issues reported by the React Compiler #42671

Merged
merged 4 commits into from
Jun 20, 2024
Merged

[joy-ui] Fix issues reported by the React Compiler #42671

merged 4 commits into from
Jun 20, 2024

Conversation

anuujj
Copy link
Contributor

@anuujj anuujj commented Jun 17, 2024 •
edited
Loading

Part of #42564

@anuujj anuujj changed the title [mui-joy] Fixed issues reported by react compiler in mui-joy components [material-ui] [mui-joy] Fixed issues reported by react compiler in mui-joy components Jun 17, 2024
@mui-bot
Copy link

mui-bot commented Jun 17, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42671--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3d0a786

@anuujj anuujj marked this pull request as draft June 17, 2024 08:57
@anuujj anuujj marked this pull request as ready for review June 17, 2024 09:12
@zannager zannager added package: material-ui Specific to @mui/material package: joy-ui Specific to @mui/joy labels Jun 17, 2024
@zannager zannager requested a review from aarongarciah June 17, 2024 11:58
@aarongarciah aarongarciah mentioned this pull request Jun 19, 2024
Open
66 tasks
aarongarciah
aarongarciah reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. In this case, we can silence all of the reported errors and leave the source code as is.

packages/mui-joy/src/Checkbox/Checkbox.tsx Outdated Show resolved Hide resolved
packages/mui-joy/src/styles/extendTheme.test.js Show resolved Hide resolved
@anuujj
Copy link
Contributor Author

anuujj commented Jun 19, 2024

@aarongarciah thank you for the feedback. I have reverted the code changes and added appropriate comments.

aarongarciah
aarongarciah approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@aarongarciah aarongarciah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@danilo-leal danilo-leal changed the title [material-ui] [mui-joy] Fixed issues reported by react compiler in mui-joy components [joy-ui] Fix issues reported by the React Compiler Jun 19, 2024
@danilo-leal danilo-leal removed the package: material-ui Specific to @mui/material label Jun 19, 2024
@mnajdova mnajdova merged commit 6c87fe3 into mui:next Jun 20, 2024
20 checks passed
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@anuujj @joserodolfofreitas
[joy-ui] Fix issues reported by the React Compiler (mui#42671)
5ca38e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongarciah aarongarciah aarongarciah approved these changes

Assignees
No one assigned
Labels
package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@anuujj @mui-bot @aarongarciah @mnajdova @danilo-leal @zannager @anuj18-kumar @siriwatknp